Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verification results are published even though not all interactions were verified #1166

Closed
tinexw opened this issue Jul 9, 2020 · 1 comment · Fixed by #1167
Closed

Verification results are published even though not all interactions were verified #1166

tinexw opened this issue Jul 9, 2020 · 1 comment · Fixed by #1167

Comments

@tinexw
Copy link
Contributor

tinexw commented Jul 9, 2020

When using JUnit 5 in combination with @FilteredPact, the verification results are always published even if not all interactions were verified. See also discussion in this PR.

Right now to me it looks like this is just not implemented for JUnit 5. I will look into it.
tinexw added a commit to tinexw/pact-jvm that referenced this issue Jul 9, 2020
@tinexw
fix: Don't publish incomplete verification results pact-foundation#1166
a069194
@tinexw tinexw mentioned this issue Jul 9, 2020
Merged
tinexw added a commit to tinexw/pact-jvm that referenced this issue Jul 9, 2020
@tinexw
fix: Don't publish incomplete verification results pact-foundation#1166
f5d01e5
tinexw added a commit to tinexw/pact-jvm that referenced this issue Jul 9, 2020
@tinexw
fix: Don't publish incomplete verification results pact-foundation#1166
0727ff4
@uglyog
Copy link
Member

uglyog commented Aug 9, 2020

4.1.7 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Don't publish incomplete verification results #1166 tinexw/pact-jvm
2 participants
@uglyog @tinexw