Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail maven build if publish verification results fails #1364

Closed
janssk1 opened this issue May 11, 2021 · 3 comments
Closed

fail maven build if publish verification results fails #1364

janssk1 opened this issue May 11, 2021 · 3 comments
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@janssk1
Copy link

janssk1 commented May 11, 2021

If the broker rejects verification results (might happen if the version used to publish is not semver compliant), the maven plugin only prints out a message.

It should (conditionally?) fail the build, making it clear that something failed. Now the build is green, but no results are published.

Version: 4.1.20
@uglyog uglyog added the bug Indicates an unexpected problem or unintended behavior label May 22, 2021
@uglyog
Copy link
Member

uglyog commented May 22, 2021

Are you using JUnit tests to verify your provders?

uglyog pushed a commit that referenced this issue May 22, 2021
fix: fail the test if publishing verification results fails #1364
76f9164
uglyog pushed a commit that referenced this issue May 22, 2021
fix: fail the test if publishing verification results fails [JUNIT5] #…
ea9c49d 
…1364
uglyog pushed a commit that referenced this issue May 22, 2021
fix: fail the verification if publishing verification results fails […
b543053 
…Maven/Gradle] #1364
@janssk1
Copy link
Author

janssk1 commented May 22, 2021

Right. Junit5. I'm using the approach documented in https://docs.pact.io/implementation_guides/jvm/provider/junit5/

uglyog pushed a commit that referenced this issue May 23, 2021
fix: HAL client must return an error if the post request fails #1364
f92fcb6
uglyog pushed a commit that referenced this issue May 23, 2021
fix: Format the error correctly when publishing results fail [Gradle/…
a5c4552 
…Maven] #1364
@uglyog
Copy link
Member

uglyog commented May 23, 2021

4.2.6 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@uglyog @janssk1 @rholshausen