Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider scala implementation dependency leaks #1395

Closed
caoilte opened this issue Jul 1, 2021 · 1 comment
Closed

provider scala implementation dependency leaks #1395

caoilte opened this issue Jul 1, 2021 · 1 comment

Comments

@caoilte
Copy link

caoilte commented Jul 1, 2021

The provider has an "implementation" dependency on Scala. I don't know how or why, but this is leaking to both kotlin and scala users of the library (leading to things like this https://pact-foundation.slack.com/archives/C9UN99H24/p1623952632261000).

Possibly you need to include the Java Library Plugin in order to make implementation dependencies work correctly? (I've never used Gradle so I could be way off.)

https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_separation
uglyog pushed a commit that referenced this issue Jul 17, 2021
chore: Remove support for scala.Function for request filters #1395
6e40178
uglyog pushed a commit that referenced this issue Jul 17, 2021
chore: Missed one place scala.Function was used #1395
527852f
@uglyog
Copy link
Member

uglyog commented Jul 21, 2021

4.2.8 is released

@uglyog uglyog closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uglyog @caoilte