HTTP Pact with root json array fails when using unordered array matching

[jakobmagiera]

I have a reproducible case where the pact specifies a request body as follows:

.body(
  newJsonArrayUnordered(
		  refs ->
				  refs.object(
						  ref ->
								  ref.stringType(
										  "id", "123")))
		  .build())

The consumer test looks like this:

HttpResponse response = Request.post(mockServer.getUrl() + "/passIdArray").bodyString("""
				[{"id":"123"}]""", ContentType.APPLICATION_JSON).execute().returnResponse();
		assertEquals(response.getCode(), 200);

This test fails (with an unhelpful Internal Server Error, but that's another issue), but the ordered variant passes.

I debugged this down to matchEqualsIgnoreOrder and then the matchEquality fallback. This ends up comparing two byte arrays (which contain the json content) with equals instead of Arrays.equals(), resulting in a false result even though the arrays are equal by content. See the attached zip for a fully functional gradle project to reproduce the effect.

PactTestArrayFailure.zip

[piotrkrokowski]

Hello. I've got the same issue. After upgrading from au.com.dius.pact.provider:junit5 from 4.3.15 to 4.3.16, some tests started failing.

After some debugging I was able to narrow down the case to MatcherExecutor.matchEqualsIgnoreOrder which apparently receives byte[] arrays as expected and actual, but defines no matchers for that type and falls back to matchEquality, as @jakobmagiera described above.

Please let me know if you need any more details.

[k-boyle]

Hello, updating from 4.3.15 introduces this for us too

[rholshausen]

/jira ticket

[github-actions]

👋 Thanks, Jira [PACT-476] ticket created.