Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AmqpTarget #383

Closed
fitzoh opened this issue Feb 26, 2017 · 3 comments
Closed

Rename AmqpTarget #383

fitzoh opened this issue Feb 26, 2017 · 3 comments

Comments

@fitzoh
Copy link
Contributor

fitzoh commented Feb 26, 2017

AmqpTarget seems to imply that it is only usable with AMQP, when there is nothing preventing it from being used to test kafka or other non-AMQP message providers.

a name of MessageTarget or something similar would make the intended usage more clear.
@uglyog
Copy link
Member

uglyog commented Mar 23, 2017

Good point, I use it to test lambda functions.

uglyog pushed a commit that referenced this issue May 21, 2020
refactor: renamed AmqpTarget to MessageTarget #383
dd8c715
@uglyog
Copy link
Member

uglyog commented May 21, 2020

Done

@uglyog uglyog closed this as completed May 21, 2020
uglyog pushed a commit that referenced this issue May 27, 2020
refactor: renamed AmqpTarget to MessageTarget #383
c04f174
@anto-ac
Copy link
Collaborator

anto-ac commented Jun 23, 2020

Should this not be renamed for JUnit5 too?

@anto-ac anto-ac reopened this Jun 23, 2020
uglyog pushed a commit that referenced this issue Jul 12, 2020
chore: [JUnit 5] rename AmpqTestTarget to MessageTestTarget #383
3d56a8a
@uglyog uglyog closed this as completed Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fitzoh @uglyog @anto-ac