Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to kotlin-logging 5 #1703

Merged
merged 1 commit into from Jul 26, 2023
Merged

upgrade to kotlin-logging 5 #1703

merged 1 commit into from Jul 26, 2023

Conversation

oshai
Copy link
Contributor

@oshai oshai commented Jul 24, 2023

No description provided.

@oshai
Copy link
Contributor Author

oshai commented Jul 24, 2023

Hi, I created a PR to upgrade kotlin-logging to v5, hope you will be open to accept it. I am the lib maintainer and since this is a breaking change and pact is pretty popular I thought to assist with the upgrade.

Locally the project is compiling now, if you can run the workflow it will help to make sure also in CI.
Notable changes:

  • replace import mu. with import io.github.oshai.kotlinlogging.
  • add dependency api 'io.github.oshai:kotlin-logging-jvm:5.0.0'. For now I kept the old dependency as a side by side, can be removed here or later to avoid breaking consumers relying on that.

What's left to do: Some methods and classes are deprecated (but still works as before). So I can change that as well in this cl, or later.

@rholshausen
Copy link
Contributor

Awesome, thanks for the PR!

@rholshausen rholshausen merged commit 494a0dc into pact-foundation:master Jul 26, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants