Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash in consumer or provider name results in folders being created #81

Open
TimothyJones opened this issue Nov 23, 2017 · 1 comment
Open

Comments

@TimothyJones
Copy link
Contributor

When the consumer or provider name contains a slash, the slash is passed through to the file system, which creates folders:

Expected behaviour

Full pact file is present in the pacts/ folder, something like: pacts/a_b client-a_b api.json

Alternatively, some kind of error that provider/consumer names are not allowed to contain slashes.

Actual behaviour

Pact file in a few folders deep: pacts/a/b client-a/b api.json

Steps to reproduce

Use the following pact() call when using pact-js:

  const provider = pact({
    consumer: 'A/B Client',
    provider: 'A/B API',
    port,
    done: error => expect(error).to.be.null
  });
@TimothyJones
Copy link
Contributor Author

Originally opened as pact-foundation/pact-js#126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant