New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for publishing verification results with a branch using the pact-ruby-standalone #327
Comments
I'm not sure we're planning on doing any more Ruby-based releases (3.x and below) in favour of Rust-based releases (4.x and above) so not sure if this will get done. |
Should we close this down @bethesque @adamrodger sounds like it won't get sorted, considering there was a PR closed, and it has been addressed in the v4.x branch? Users should navigate to Upgrading from PactNet v3.x or earlier to v4.x |
Yeah I'd close it. I doubt it's gonna get done
…On Fri, 29 Apr 2022, 15:44 Yousaf Nabi, ***@***.***> wrote:
Should we close this down @bethesque <https://github.com/bethesque>
@adamrodger <https://github.com/adamrodger> sounds like it won't get
sorted, considering there was a PR closed, and it has been addressed in the
v4.x branch?
Users should navigate to Upgrading from PactNet v3.x or earlier to v4.x
<https://github.com/pact-foundation/pact-net#upgrading-from-pactnet-v3x-or-earlier-to-v4x>
—
Reply to this email directly, view it on GitHub
<#327 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD4FKXRZOBQSOKN25VKOIDVHPYTPANCNFSM5E7AQPQQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This seems like a fairly trivial change for a useful feature and is key to removing the dependency on tags, in favour of branches/environments/deployments. Given that most Pact .NET users would not be on the new beta, and changing to the 4.x.x line is non-trivial on behalf of the user, why would we not do this? |
It should be a very small change and it would be great for the languages to have feature parity for the branches/envs. |
There was a PR done for the change in v3 #345 by @mchwalek (thank you!) however based on this comment #345 (comment) it stalled, and was closed/continued on the v4 branch via #346 |
Mmm quite a conundrum. A major release of the ruby based package would overlap with the new 4.x.x and cause even more confusion. Although it's ugly, is a setter method on The alternative is that nobody gets the feature. |
I'm not planning on doing any more 3.x feature releases and instead focussing on 4.x and above, so this issue can now be closed. |
The Pact Broker now supports branches as first class entities. You can read more about this here: https://github.com/pact-foundation/docs.pact.io/blob/feat/deployments-and-releases/website/blog/2021-07-04-why-we-are-getting-rid-of-tags.md
To allow users to use this feature:
1.88.70
--provider-version-branch
The text was updated successfully, but these errors were encountered: