Add an option where the consumer of the library can set the host #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcampbell
requested changes
Nov 8, 2017
| { | ||
|
|
||
| var sslOption = enableSsl ? " --ssl" : ""; | ||
| return $"-p {port} -l \"{logFilePath}\" --pact-dir \"{pactFileDir}\" --pact-specification-version \"{pactSpecificationVersion}\" --consumer \"{consumerName}\" --provider \"{providerName}\"{sslOption}"; | ||
| var hostOption = string.IsNullOrWhiteSpace(host) ? "" : $" --host={host}"; |
There was a problem hiding this comment.
Can we flip the condition so the else case is ""? Same as the one above.
| : this( | ||
| baseUri => new RubyHttpHost(baseUri, consumerName, providerName, config), | ||
| baseUri => new RubyHttpHost(baseUri, consumerName, providerName, config,host), |
There was a problem hiding this comment.
RubyHttpHost should not need to take in the host, you should update the baseUri to reflect the host that is being used.
This is done by passing host to the MockProviderService internal ctor and changing BaseUri = new Uri($"{(enableSsl ? "https" : "http")}://localhost:{port}"); to BaseUri = new Uri($"{(enableSsl ? "https" : "http")}://{host}:{port}");
| consumerName, | ||
| providerName, config)), | ||
| providerName, config, host)), |
There was a problem hiding this comment.
Once below comment is actioned you can use baseUri.host
neilcampbell
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for this issue pact-foundation/pact-mock_service#79