feat: Allow publishing verification results for URI sources (#392) #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #392 (comment) for where the verification results URL comes from. |
|
This can be merged when it has a related FFI update which includes feature pact-foundation/pact-reference#199 The PactNet side shouldn't need changing further because the actual change is on the FFI side. As long as we call the |
adamrodger
added a commit
that referenced
this pull request
Jul 13, 2022
adamrodger
force-pushed
the
feat/publish-uri-results
branch
from
234b5ea
to
5c97ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the linked issue #392 for additional information
Draft currently as it's unclear where the broker URI is going to come from. Perhaps this is built into the FFI, but that doesn't seem safe to me.