chore: Upgrade FFI to 0.3.8 #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The integration tests will need to be changed also for an FFI upgrade. You can run all the tests locally to see the required mods |
omajid
force-pushed
the
update-ffi-0.3.8
branch
from
8767304
to
b4304dc
Compare
|
Thanks. Sorry, I see some test failures. Debugging them now. |
This version of ffi on Linux only needs glibc 2.24 to run, which should make us more compatible across a larger set of Linux distributions.
omajid
force-pushed
the
update-ffi-0.3.8
branch
from
b4304dc
to
aab74f0
Compare
|
Tests pass locally now. |
|
Hey folks! Is this okay to merge? |
|
Thanks! |
|
Hey @adamrodger, do you know when it would be reasonable to expect to see a Pact-Net release with this FFI version? |
|
Nvm, I see https://github.com/pact-foundation/pact-net/releases/tag/4.2.0 now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of ffi on Linux only needs glibc 2.24 to run, which should make us more compatible across a larger set of Linux distributions.
Fixes: #402