-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version of dependencies #71
Conversation
For ease, you can check the appveyor output from our PR here. |
@andy-c-jones Thanks for the PR and sorry it has taken so long to respond! Did you have issues installing PactNet with newer versions of the dependencies? |
I believe I did have an issue with newer versions of the dependencies but I can't remember which one off the top of my head. I am going to try and recreate the issue in a sample project. |
Either way, given the "min version required" strategy this whole PR would be unsuitable to merge. If I can recreate the problem I will open an issue and/or a new PR. |
@andy-c-jones Thanks for that! If you can re-create let me know, would be keen to hear about it. |
Due to different (and old) version dependencies @MarkDaviesEsendex and I found it useful to have a version that used the latest versions of pact-net's dependencies. Mainly Newtonsoft.Json and Nancy but some of the other dependencies seemed like pretty low risk to update .
All tests still pass and we have used the package produced by my forks appveyor build in a project that makes use of pact-net in earnest so we believe it is a worthwhile change.
Feel free to ignore this PR if these version updates are unwanted but I thought it was worth offering the changes if you are interested.
The only dependencies we didn't touch were LibLog and xunit because bringing those up to date was a little more involved and didn't provide us with any value.