Make mock server host and port optional

pact-foundation · May 10, 2023 · 2d5b22c · 2d5b22c
1 parent d6a41d0
commit 2d5b22c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 10 deletions.
diff --git a/example/phpunit.all.xml b/example/phpunit.all.xml
@@ -29,8 +29,6 @@
         </listener>
     </listeners>
     <php>
-        <env name="PACT_MOCK_SERVER_HOST" value="localhost"/>
-        <env name="PACT_MOCK_SERVER_PORT" value="7200"/>
         <env name="PACT_CONSUMER_NAME" value="someConsumer"/>
         <env name="PACT_CONSUMER_VERSION" value="1.0.0"/>
         <env name="PACT_CONSUMER_TAG" value="master"/>

diff --git a/example/phpunit.consumer.xml b/example/phpunit.consumer.xml
@@ -17,8 +17,6 @@
         </listener>
     </listeners>
     <php>
-        <env name="PACT_MOCK_SERVER_HOST" value="localhost"/>
-        <env name="PACT_MOCK_SERVER_PORT" value="7200"/>
         <env name="PACT_CONSUMER_NAME" value="someConsumer"/>
         <env name="PACT_CONSUMER_VERSION" value="1.0.0"/>
         <env name="PACT_CONSUMER_TAG" value="master"/>

diff --git a/example/phpunit.core.xml b/example/phpunit.core.xml
@@ -17,8 +17,6 @@
         </listener>
     </listeners>
     <php>
-        <env name="PACT_MOCK_SERVER_HOST" value="localhost"/>
-        <env name="PACT_MOCK_SERVER_PORT" value="7200"/>
         <env name="PACT_CONSUMER_NAME" value="someConsumer"/>
         <env name="PACT_CONSUMER_VERSION" value="1.0.0"/>
         <env name="PACT_CONSUMER_TAG" value="master"/>

diff --git a/phpunit.xml b/phpunit.xml
@@ -18,8 +18,6 @@
     <junit outputFile="./test_results/reports/unit_test_results.xml"/>
   </logging>
   <php>
-    <env name="PACT_MOCK_SERVER_HOST" value="localhost"/>
-    <env name="PACT_MOCK_SERVER_PORT" value="7200"/>
     <env name="PACT_CONSUMER_NAME" value="someConsumer"/>
     <env name="PACT_CONSUMER_VERSION" value="1.0.0"/>
     <env name="PACT_PROVIDER_NAME" value="someProvider"/>

diff --git a/src/PhpPact/Standalone/MockService/MockServerEnvConfig.php b/src/PhpPact/Standalone/MockService/MockServerEnvConfig.php
@@ -14,8 +14,14 @@ class MockServerEnvConfig extends MockServerConfig
      */
     public function __construct()
     {
-        $this->setHost($this->parseEnv('PACT_MOCK_SERVER_HOST'));
-        $this->setPort((int) $this->parseEnv('PACT_MOCK_SERVER_PORT'));
+        if ($host = $this->parseEnv('PACT_MOCK_SERVER_HOST', false)) {
+            $this->setHost($host);
+        }
+
+        if ($port = $this->parseEnv('PACT_MOCK_SERVER_PORT', false)) {
+            $this->setPort((int) $port);
+        }
+
         $this->setConsumer($this->parseEnv('PACT_CONSUMER_NAME'));
         $this->setProvider($this->parseEnv('PACT_PROVIDER_NAME'));
         $this->setPactDir($this->parseEnv('PACT_OUTPUT_DIR', false));