Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow PSR-2 codingsstandards #12

Closed
ruudk opened this issue Oct 9, 2017 · 6 comments
Closed

Follow PSR-2 codingsstandards #12

ruudk opened this issue Oct 9, 2017 · 6 comments
Assignees

Comments

@ruudk
Copy link
Contributor

ruudk commented Oct 9, 2017

Sorry to say, but on some places, the code is really a mess.

It would be great if we could follow the PSR-2 standard.

We can even automatically fix the current code with https://github.com/friendsofphp/php-cs-fixer

If no big refactors are happening right now, I can try to run it and create a PR for it? It needs to be merged fast because it will be annoying for others that are working on improvements and having to rebase.

@mattermack
Copy link
Contributor

I'm game. I have a separate request to follow PSR-3 but no pull requests yet. I do not have major fixes in the works yet. I'm starting to work on v2. That said, with such a large refactor as you mentioned, we really need AppVeyor running on pull requests

@ruudk
Copy link
Contributor Author

ruudk commented Oct 9, 2017

BTW, Why are you using AppVeyor? If it's hard to set up on pull requests we could use Travis?

@mattermack
Copy link
Contributor

As I mentioned, Windows is my primary concern and AppVeyor does a good job at that. AppVeyor should be setup appropriately now.

@mattermack
Copy link
Contributor

I'm going to see if I can pull this off today.

mattermack pushed a commit that referenced this issue Oct 9, 2017
Follow PSR-2 codingsstandards #12
@mattermack mattermack self-assigned this Oct 9, 2017
@mattermack
Copy link
Contributor

This was a great idea. I plugged php-cs-fixer into AppVeyor.

Merged to master but not re-tagged

@ruudk
Copy link
Contributor Author

ruudk commented Oct 9, 2017

Nice!

YOU54F added a commit that referenced this issue Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants