Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: phpstan level 7 #290

Merged
merged 10 commits into from
Apr 28, 2023
Merged

Conversation

WaylandAce
Copy link
Contributor

Increase phpstan check level to 7.
Drop obvious phpdocs

src/PhpPact/Consumer/Hook/ContractDownloader.php Outdated Show resolved Hide resolved
src/PhpPact/Consumer/Listener/PactTestListener.php Outdated Show resolved Hide resolved
src/PhpPact/Consumer/Model/ConsumerRequest.php Outdated Show resolved Hide resolved
@tienvx
Copy link
Contributor

tienvx commented Mar 1, 2023

Hi @WaylandAce , can you resolve remaining reviews so I can approve and rebase my pull request base on your pull requests?

@WaylandAce
Copy link
Contributor Author

@tienvx ok, tomorrow will check

@YOU54F YOU54F merged commit 44fa06d into pact-foundation:master Apr 28, 2023
@YOU54F
Copy link
Member

YOU54F commented Apr 28, 2023

Thanks @WaylandAce much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants