-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: phpstan level 7 #290
Merged
YOU54F
merged 10 commits into
pact-foundation:master
from
WaylandAce:chore/phpstan-level7
Apr 28, 2023
Merged
chore: phpstan level 7 #290
YOU54F
merged 10 commits into
pact-foundation:master
from
WaylandAce:chore/phpstan-level7
Apr 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tienvx
reviewed
Feb 14, 2023
src/PhpPact/Standalone/StubService/Service/StubServerHttpService.php
Outdated
Show resolved
Hide resolved
Hi @WaylandAce , can you resolve remaining reviews so I can approve and rebase my pull request base on your pull requests? |
@tienvx ok, tomorrow will check |
Thanks @WaylandAce much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase phpstan check level to 7.
Drop obvious phpdocs