Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test stub server health check #294

Merged
merged 1 commit into from Apr 28, 2023

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Mar 6, 2023

I saw we have the code but doesn't have the test for it. I wrote it so I verify that this feature did exist

@YOU54F
Copy link
Member

YOU54F commented Apr 28, 2023

Nice spot!

Screenshot 2023-04-28 at 18 54 48

  1. clone repo git clone https://github.com/pact-foundation/pact-php.git
  2. run composer update
  3. $PWD/src/PhpPact/Standalone/Installer/Model/../../../../../bin/pact-ruby-standalone/bin/pact-stub-service example/output/someconsumer-someprovider.json

in another terminal

  1. curl http://localhost:52388 -H "X-Pact-Stub-Service: true"
  • {"message":"No interaction found for GET /","interaction_diffs":[]}
  1. curl http://localhost:52388 -H "X-Pact-Mock-Service: true"
  • Mock service running

@YOU54F
Copy link
Member

YOU54F commented Apr 28, 2023

Thanks for adding a test 🙌🏾

@YOU54F YOU54F merged commit 4cbc3db into pact-foundation:master Apr 28, 2023
@YOU54F YOU54F self-requested a review April 28, 2023 17:59
Copy link
Member

@YOU54F YOU54F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tien, tested and was able to reproduce so thanks for correcting and adding a test

@tienvx tienvx deleted the test-stub-server-health-check branch May 8, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants