Run php cs fixer on PHP 8.2 #301
Conversation
|
I think to speedup code style checks and not to make redundant work it is enough to use the latest version of PHP. I can't imagine a situation where a linter under PHP 8.2 won't find something that a linter working under PHP 8.1 will find. |
|
Hi @sergeyklay I agree with you. I also has similar question in my previous PR #278 (comment) I removed PHP 8.0 and 8.1 |
|
Thanks for helping with the review on this @sergeyklay, @tienvx will greatly appreciate the feedback, it has been a slow cycle in pact-php but we would love to keep it going for our community. We've been lucky to have a few collaborators over the last year but some of the similar issues to pact-python regarding maintainership, and being able to help with reviews and nudge stuff along. Tien has kindly stepped up to the plate on the back of great work done by @mmoll / @Lewiscowles1986 and others. |
|
@tienvx I have experience with PHP, so ping me anytime |
|
Not sure why I'm being thanked, but I feel awkward now for not being more active. https://github.com/pact-foundation/pact-php/actions/runs/4403773326/jobs/7712576073?pr=301 seems to have failed, but I'm betting that a retry will see it green. Is there perhaps some way to log separately to a file on the entry and exit to each flow? Where this launches processes still, I am sure that is where the problem lays. I definitely cannot look this weekend (UK Mothers day), but deterministic test-runs to the shared network resource might be the ticket (might). This should not need to guarantee test case ordering, just that the steps in every test case are clean and have no races. |
Sorry just thanking for past efforts to date, not wanting to make you feel bad or trying to pull you into help more. We are keen to act on some of your prior comments as your feedback was incredibly useful Lewis, so just trying to bring others into the fold and thank others in the process! |
PHP-CS-FIXER released version 3.15 with PHP 8.2 support