MockServerConfig defaults and pact-php speed enhancements #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix config setters returning a interface which prevents chaining when static analysis tools are in use as the interfaces are only a subset of what the class can do. * Set defaults similar to MockServerEnvConfig for timeouts as these are typed but not set to a value by default, forcing you to set them to avoid an error.
Pact consumer tests are supposed to be like unit tests but mine were taking 2 seconds+ each, the majority of which was a php sleep() Lots of unnecessary sleeps were slowing down my api and message tests. * Allow SetHealthCheckRetrySec / PACT_MOCK_SERVER_HEALTH_CHECK_RETRY_SEC to be a float so it can be set to 0.1 instead of 1. * Use usleep instead of sleep so that the retry seconds can be a < 1 second. * Increase the total number of attempts so it still tries for ~10 seconds. * Remove sleeps when PactMessage which do not appear to be needed.
This was referenced Jul 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of @slt's changes in #316 and #315 with appropriate commit messages.