Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Closing socket connection after opening it #328

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Jul 28, 2023

Attempt to fix the timeout error like this:

 There was 1 error:

1) PhpPactTest\Standalone\ProviderVerifier\VerifierTest::testVerify
Symfony\Component\Process\Exception\ProcessTimedOutException: The process "php -S 127.0.0.1:7202 -t "D:\a\pact-php\pact-php\tests\PhpPact\Standalone\ProviderVerifier/../../../_public/"" exceeded the timeout of 60 seconds.

D:\a\pact-php\pact-php\vendor\symfony\process\Process.php:1263
D:\a\pact-php\pact-php\vendor\symfony\process\Process.php:468
D:\a\pact-php\pact-php\tests\PhpPact\Standalone\ProviderVerifier\VerifierTest.php:25

Link to failed job

@tienvx tienvx changed the title chore: Disable process timeout chore: Closing socket connection after opening it Jul 29, 2023
@YOU54F YOU54F self-requested a review August 1, 2023 11:17
Copy link
Member

@YOU54F YOU54F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, we can see the failure shown on the latest merge to the ffi branch prior to this change

@YOU54F YOU54F merged commit 65ca319 into pact-foundation:ffi Aug 1, 2023
26 checks passed
@YOU54F
Copy link
Member

YOU54F commented Aug 1, 2023

@tienvx
Copy link
Contributor Author

tienvx commented Aug 1, 2023

This error's driving me crazy

@tienvx tienvx deleted the disable-process-timeout branch August 1, 2023 11:53
@YOU54F
Copy link
Member

YOU54F commented Aug 1, 2023

Oh man I feel your pain, having been battling with a few odd cross platform issues of late

@tienvx
Copy link
Contributor Author

tienvx commented Aug 18, 2023

I am able to reproduce the error in https://github.com/tienvx/test-php-built-in-server-timeout, but I can't fix it, because I don't know what is happening. Maybe something related to php 8.2 + ffi extension + Windows server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants