revert: Values matcher accept keys again

[tienvx]

Revert #356

I was wrong #356 is a feature, not a bug.

• When you pass array without keys to values matcher, it compare values using its index (i.e. starting with 0) in the array.
• When you pass array with keys to values matcher, it compare values using those keys.
• Missing keys/indexes are OK.
• Additional keys/indexes are NOT OK.
  • I'm not sure about this behavior.
  • Pact complain that the value of additional keys/indexes must equals to the first value (e.g. a) ???
  • Probably because I'm testing this values matcher on Response?
  • If using this values matcher on Request, additional keys/indexes are OK. See this behavior on compatibility suite

I'm not really understand the behavior of missing/additional keys/indexes. Look like it's the Postel's law, but in revert?

[tienvx]

A friendly remind for @YOU54F and @JP-Ellis . Please take a look when you have time. Thanks

[JP-Ellis]

My bad! This one did drop off my radar. I'm look at it tomorrow

[JP-Ellis]

As far as the PR changes, this all looks good to me.

As for the questions you raise above, that's maybe best answered by @rholshausen?

[rholshausen]

values is for use with maps, not arrays. I've never tried to use it with arrays, but I'd imagine it will either be a no-op or act like a type matcher on the array.

wrt question about additional keys/indexes, what do you compare these additional values to?

For instance, given the map {"a":"A","b":"B"}, using the values matcher you are indicating that the keys (a, b) should be ignored, and only the values be compared. I.e., it bascially treats the map as the array ["A", "B"] and compares that.

[tienvx]

Look like it's a bug to me. I created a separated issue for it here pact-foundation/pact-reference#337

[tienvx]

Merged as this code has been approved.