refactor: Add RandomDecimal generator class #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lewiscowles1986
approved these changes
Dec 13, 2023
Comment on lines
+10
to
+26
| class RandomDecimal implements GeneratorInterface | ||
| { | ||
| public function __construct(private int $digits = 10) | ||
| { | ||
| } | ||
|
|
||
| /** | ||
| * @return array<string, string|int> | ||
| */ | ||
| public function jsonSerialize(): array | ||
| { | ||
| return [ | ||
| 'digits' => $this->digits, | ||
| 'pact:generator:type' => 'RandomDecimal', | ||
| ]; | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm interested by this. It feels like an abstract class, as it does not contain the generation of a random decimal. While "clean", I feel like that could lead to user surprise.
Didn't the UUID manage reading or generating?
There was a problem hiding this comment.
No, the Uuid class didn't generate any values either https://github.com/pact-foundation/pact-php/pull/382/files#diff-b623d134377ef4d335b9e73f1a4d698c09f815e4d0c21fa375251086d83d855c
There was a problem hiding this comment.
I feel like that could lead to user surprise.
I also agree that the naming of these classes is not good, as we call them generators, but they doesn't generate any value.
Any suggestions would be great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator is defined at https://github.com/pact-foundation/pact-specification/tree/version-4#supported-generators