Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add Regex matcher class #391

Merged
merged 2 commits into from Dec 15, 2023
Merged

refactor: Add Regex matcher class #391

merged 2 commits into from Dec 15, 2023

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Dec 13, 2023 •
edited

@tienvx tienvx mentioned this pull request Dec 13, 2023
Closed
Lewiscowles1986
Lewiscowles1986 suggested changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@Lewiscowles1986 Lewiscowles1986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove the (object)?

@tienvx
Copy link
Contributor Author

tienvx commented Dec 15, 2023

Reverted to array

@tienvx tienvx merged commit 5a59f42 into pact-foundation:ffi Dec 15, 2023
23 of 26 checks passed
@tienvx tienvx deleted the add-regex-matcher-class branch December 15, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lewiscowles1986 Lewiscowles1986 Lewiscowles1986 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tienvx @Lewiscowles1986