Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add Includes matcher class #403

Merged
merged 1 commit into from
Dec 17, 2023
Merged

refactor: Add Includes matcher class #403

merged 1 commit into from
Dec 17, 2023

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Dec 15, 2023

Lewiscowles1986
Lewiscowles1986 approved these changes Dec 17, 2023
View reviewed changes
Copy link
Collaborator

@Lewiscowles1986 Lewiscowles1986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Note for the PACT team that if to explain includes, you use contains. Contains is a better word!

@tienvx
Copy link
Contributor Author

tienvx commented Dec 17, 2023

I also agree that Contains is better word.

We can discuss about this in Slack later.

For now I would like to keep this Includes word to make it consistent with the table in the specification.

@tienvx tienvx merged commit 2bc7099 into pact-foundation:ffi Dec 17, 2023
26 checks passed
@tienvx tienvx deleted the add-includes-matcher-class branch December 17, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lewiscowles1986 Lewiscowles1986 Lewiscowles1986 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tienvx @Lewiscowles1986