Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove old composer script #423

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Dec 19, 2023

This script is from version <=9.

In version 10 I refactored the example/ directory.

The public path in the script is not correct any more. And I don't think this script is useful. So I removed it.

@Lewiscowles1986
Copy link
Collaborator

Is it a case that there has been a breakage in this script in the refactor?

I'm all for removing it if the pipeline passes (which it does); but I'd just like to understand a little more.

@tienvx
Copy link
Contributor Author

tienvx commented Dec 20, 2023

Here is the old index.php file.
Here is the new index.php file.

I don't change it much. I think the script is still working fine (just change the public's path).

But I think it's not useful. I can't think of any reason the script must be there.

@tienvx
Copy link
Contributor Author

tienvx commented Dec 20, 2023

I tried remove that script and run tests on master branch and all tests are passed.

@tienvx tienvx merged commit 8a61f21 into pact-foundation:ffi Dec 20, 2023
26 checks passed
@tienvx tienvx deleted the remove-composer-script branch December 20, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants