New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move xml to core #434

Merged

tienvx merged 1 commit into pact-foundation:ffi from tienvx:move-xml-to-core

Dec 27, 2023

Contributor

tienvx commented Dec 27, 2023

Move code from xml to this repo
Update code
- Change namespace
- Remove this (object) type casting https://github.com/tienvx/pact-php-xml/blob/main/src/XmlElement.php#L104 to make tests pass. I remember it's just a hack to make tests pass in the original repo.
Update tests
- Handle new line (\n to \r\n) on Windows
- Move Integration/XmlBuilder to XmlBuilderIntegrationTest


          refactor: Move xml to core

d9b5b47

tienvx requested a review from Lewiscowles1986

December 27, 2023 03:33

Lewiscowles1986 approved these changes

View reviewed changes

tienvx merged commit 9e49b17 into pact-foundation:ffi

24 of 30 checks passed

tienvx deleted the move-xml-to-core branch

December 27, 2023 04:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment