refactor!: Move protobuf code to core #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tienvx
commented
Jan 7, 2024
tienvx
commented
- Move code from protobuf to this repo
- Only move the code, there are 2 examples for protobuf and will be in separated PRs
- No tests for these code yet
Lewiscowles1986
approved these changes
Jan 8, 2024
|
Would be nicer to have tests with these "move to core" bits; or to have a link to existing tests these impact. |
|
There are no unit tests in original repository yet. Writing unit tests take more time than writing the code itself, and because I'm not confident with the code yet, I just want to delay writing the unit tests so I don't have to update it later when I'm updating the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.