Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Merge PactDriver and PactRegistry #494

Merged
merged 1 commit into from Feb 29, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Feb 27, 2024

  • Add Pact class with pact handle
  • Merge PactRegistry to PactDriver
    • Store created pact object
    • Call setUp in __construct()
  • Update PactDriverInterface
    • Remove setUp()
    • Add getPact()
  • Update compatibility suite, factories, registries ... reflect these changes

@Lewiscowles1986
Copy link
Collaborator

Is it my imagination or has the networking got worse since the "networking fix"?

@tienvx
Copy link
Contributor Author

tienvx commented Feb 29, 2024

I tried to revert but:

  • On macos 14 (arm): something wrong with github actions, I can't find solution for this error dyld[7202]: Library not loaded: /opt/homebrew/opt/xz/lib/liblzma.5.dylib
  • On windows: The annoying error Script phpunit --no-coverage handling the test event returned with error code -1073741510 is still there + timeout error (I think something wrong with Github Actions)

so, no, I think something wrong with Github Actions itself. The fix does nothing. I will create PR to revert it.

@tienvx tienvx merged commit 0795996 into pact-foundation:ffi Feb 29, 2024
21 of 30 checks passed
@tienvx tienvx deleted the refactor-pact-driver branch February 29, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants