Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Test FFI Client #528

Merged
merged 2 commits into from
Mar 9, 2024
Merged

test: Test FFI Client #528

merged 2 commits into from
Mar 9, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Mar 8, 2024

No description provided.

Copy link
Collaborator

@Lewiscowles1986 Lewiscowles1986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These feel like useless changes. Would you mind explaining a little bit as to the value of this code?

@tienvx
Copy link
Contributor Author

tienvx commented Mar 9, 2024

The purpose of this test is only to increase code coverage

@Lewiscowles1986
Copy link
Collaborator

Right but in this case it's nonsense coverage. If you were to run infection over this type of coverage it might still be low, because as one of the tests states, there are no assertions. We're simply expecting that calling something won't explode.

@tienvx
Copy link
Contributor Author

tienvx commented Mar 9, 2024

Replaced pactffi_string_delete by pactffi_check_regex which return a result. Added an assertion to assert the result. Does it look a bit better?

@tienvx tienvx merged commit 175aaf0 into pact-foundation:ffi Mar 9, 2024
26 checks passed
@tienvx tienvx deleted the test-ffi-client branch March 9, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants