Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Avro plugin 0.0.4 #47

Merged
merged 1 commit into from Dec 4, 2023

Conversation

austek
Copy link
Contributor

@austek austek commented Nov 30, 2023

Add Avro plugin 0.0.4


[[entries.avro.versions.manifest.dependencies]]
name = "jvm"
version = "17+"
Copy link
Member

@YOU54F YOU54F Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did previous versions actually require Java17 not Java 11?

Should we retrospectively update 0.0.3 to 17+?

Related comment and PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the new version is binary compatible, upgrading is safe for any end user

Copy link
Member

@YOU54F YOU54F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but just a suggestion on the java version for the older version 0.0.3 as I believe it is 17 not 11, which may warrant being applied retrospectively

Happy to approve this as is without that change being made however

@YOU54F YOU54F merged commit f57ddf3 into pact-foundation:main Dec 4, 2023
20 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants