Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set "enable pending" to true by default #264

Closed
bethesque opened this issue Sep 15, 2021 · 1 comment
Closed

Set "enable pending" to true by default #264

bethesque opened this issue Sep 15, 2021 · 1 comment

Comments

@bethesque
Copy link
Member

The pending feature has been used for long enough now to show that it works, and that there is little reason to ever have it turned off any more. The Pact Broker now defaults to true if the includePendingStatus field is not set, however, this will not take effect if the client side has it set to false by default. Please set enablePending to true by default now, to ensure it is turned on for all older and future versions of the Pact Broker.

Consider printing a warning message if the user does set it to false explicitly, along the lines of "We recommend setting enablePending to true. For more information, please see https://docs.pact.io/pending"

@bethesque
Copy link
Member Author

On further discussion within the maintainers group, I'm convinced that this should be considered a breaking change, and should therefore required a major version release. There are some non-breaking changes I'd like to have added to the Pact clients before the next major release (so as many people as possible can start using them without having to do a major version upgrade, which people tend not to do unless necessary) so please hold off on this for now. I will re-open this at a later stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant