feat(matcher): Allow bytes type in from_term function #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-badger
force-pushed
the
add-bytes-support-for-from-term
branch
from
23ab5e9
to
1d8a225
Compare
|
And this works for you? Just checking as I haven't run it locally |
|
I am unable to run |
|
More meant you were comfortable it is testing what you think it is. It looks like it. |
|
Oh, yes. The traceback I ran into led me to that place, and we just need the return value to be what it is. |
|
Thanks @elliottmurray ! |
|
No thank you! At some point I'll fix my local env and trigger a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #241, wherein using bytes is not a valid option for either request or response content.