Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove dead code #330

Merged
merged 2 commits into from
Apr 2, 2023
Merged

fix: remove dead code #330

merged 2 commits into from
Apr 2, 2023

Conversation

sergeyklay
Copy link
Member

@sergeyklay sergeyklay commented Mar 5, 2023 •
edited

  • missing_files was set twice, the second time is not used
  • provider_app_version was set twice with the same value
  • removed unnecessary brackets
  • fix link for GitHub badge

@sergeyklay
Copy link
Member Author

/cc @elliottmurray

@sergeyklay sergeyklay self-assigned this Mar 30, 2023
@sergeyklay
fix: remove dead code
2259d17 
- missing_files was set twice, the second time is not used
- provider_app_version was set twice with the same value
- removed unnecessary brackets
@sergeyklay
docs: fix link for GitHub badge
e2ac34f
mike-geeves-oxb
mike-geeves-oxb approved these changes Apr 2, 2023
View reviewed changes
Copy link

@mike-geeves-oxb mike-geeves-oxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Standardising READMEs would be nice to try and do, all of the different projects look a little different, but that's for another PR :)

mikegeeves
mikegeeves approved these changes Apr 2, 2023
View reviewed changes
Copy link
Contributor

@mikegeeves mikegeeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try from the right account 🤦

LGTM

Standardising READMEs would be nice to try and do, all of the different projects look a little different, but that's for another PR :)

@sergeyklay sergeyklay merged commit 28fc7d3 into pact-foundation:master Apr 2, 2023
7 checks passed
@sergeyklay sergeyklay deleted the fix/code-cleanup branch April 2, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikegeeves mikegeeves mikegeeves approved these changes

@mike-geeves-oxb mike-geeves-oxb mike-geeves-oxb approved these changes

Assignees

@sergeyklay sergeyklay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sergeyklay @mikegeeves @mike-geeves-oxb