Fix CORS parameter not doing anything #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mefellows
reviewed
Apr 15, 2023
pact/pact.py
Outdated
| @@ -214,6 +214,8 @@ def start_service(self): | |||
| command.extend(['--sslcert', self.sslcert]) | |||
| if self.sslkey: | |||
| command.extend(['--sslkey', self.sslkey]) | |||
| if self.cors: | |||
| command.extend(['--cors=*']) | |||
There was a problem hiding this comment.
Why the =*? I think just passing this without arguments (i.e. treat it as a flag) is all that is needed.
Or is this something specific to the way the python CLI lib interacts?
There was a problem hiding this comment.
I tested it without passing =* and it works fine.
The documentation of the mock server tells me that an argument must be provided
pact\bin\pact\bin\pact-mock-service.bat help start
-o, [--cors=CORS] # Support browser security in tests by responding to OPTIONS requests and adding CORS headers to mocked responses
But because self.cors is a boolean there is no way to pass different options for the cors parameter and it is
therefore better to append --cors without any value.
For now I pushed an update that removes =* from the command.
If the cors parameter is set to True '--cors=*' is appended to the list of commands for the external mock service. Previously the parameter was ignored.
Lukas-dev-threads
force-pushed
the
fix-cors
branch
from
61d27c4
to
19be499
Compare
YOU54F
approved these changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that pact ignores the CORS parameter of the
Consumer.has_pact_with()function.If the CORS parameter is set to True
--cors=*is appended to the list of commands for the external mock service.The mock service itself already supports this parameter.