Feat/ffi - load full ffi namespace, initial ffi verifier #357

YOU54F · 2023-07-08T13:17:35Z

Following on from the awesome work from @elliottmurray and @mikegeeves

Will document properly over the next couple of days, (probably next week)

as part of the ffi maintainers guide
pulling out other sources of pact verifications (both ruby, rust and jvm backed) so they can be referenced by others
work out where any discrepancies lie
where any logic is shared across client libraries and can be moved into the core
quality of life improvements to any ffi methods to aid maintainers/library creators

Work done so far

Loading of shared binaries for the following platform

OS	Architecture
OSX	x86_64
Linux	x86_64
OSX	arm64
Linux	arm64
Windows	x86_64

Full FFI namespace available by loading pact.h header file
FFIVerify class created
MessageProvider updated to support verification message pacts with rust core
MessageProvider now returns same result signature as FFIVerify based on Verifier
FastApi / FlaskAPI Provider's updated to verify with new FFIVerify
Message Provider updated to verify with new FFIVerify
gRPC v4 pact verification example based on area_calculator.proto used in https://github.com/pact-foundation/pact-plugins/tree/main/examples/gRPC/area_calculator
- Pact was actually generated from this python grpc consumer example https://github.com/pact-foundation/pact-reference/blob/master/python/pact_plugin_grpc_v4.py in the pact-reference repo

TODO

Message metadata content-type currently hard coded to application/json
Plugin tests when they fail, dont appear to return the failures or successes to the log buffer
Log level gets globally applied, and isn't able to be changed, which interferes with the unit tests, and probably external tests within the same process. I think this is due to pact-reference using a global logging tracer.
write migration guide
bump to alpha version

…e changes to docker37 which I will need to do to all

…ing by the tox list)

…nor doc tidy

The return code is straightforward, but having problems with the logging. When setting up the FFI objects etc, it doesn't seem to work unless it's a basically a singleton, it seems hard to split up. I don't like it but going with this for now :)

…pper

…tiple

…fi_free_string to cleanup

…tch_log_buffer

TODO - Message Metadata Content-Type hardcoded to application/json - Allow switching between rust/ruby core whilst in beta Notes - Message HTTP proxy needs to drop `contents`

most likely due to container, see workaround in GHA

use area calculator proto example matching up with other pact grpc examples. Pact is precreated and not currently generated from pact-python

YOU54F · 2023-07-26T22:14:13Z

Not sure why Snyk is complaining, I can't see the detail behind the check without logging into snyk, and my gh user doesn't have access.

Should it be reporting back to the PR as a comment?

🤔

seems to causing hanging tests on windows

YOU54F · 2023-08-02T22:05:10Z

superseded by #367

elliottmurray and others added 30 commits July 17, 2021 13:26

feat: added rust linux/osx support

4fdabdd

feat: fix to pytest request signature@

2d7f943

feat: first ffi interface

488d55f

feat: added so file

cf77d09

fix: so now a relative path so picked up by tests (temp fix) Also som…

f914c50

…e changes to docker37 which I will need to do to all

chore: move dyn libs to libs folder@

cd85969

feat: some work on preparing verify call

2b67e39

feat: refactoring to prepare verify

60ac756

feat: added rust linux/osx support

34f67a7

feat: fix to pytest request signature@

afd0931

feat: first ffi interface

6c95248

feat: added so file

de93a1f

fix: so now a relative path so picked up by tests (temp fix) Also som…

be6c971

…e changes to docker37 which I will need to do to all

chore: move dyn libs to libs folder@

4b239e4

feat: some work on preparing verify call

e7d686a

feat: refactoring to prepare verify

050ee0e

docs(readme): trivial 'hello world' changes :)

7d18a2f

docs(readme): update python versions mentioned to those supported (go…

214c47d

…ing by the tox list)

build(flake8): exclude venv and tox dirs from flake8 linting

a84f856

build(ffi): use libs from pact dir instead of libs. Bump to 0.0.1. Mi…

2d30706

…nor doc tidy

feat(ffi verifier): very basic call of verify, with no args

c6ded0a

feat(ffi verifier): verifier test, looking at log output

358748f

feat(ffi verifier): set log level for output

070f905

feat(ffi verifier): help and version tests

cf0bfee

feat(ffi verifier cli): use FFI to determine the args for the CLI wra…

3471c12

…pper

feat(ffi verifier): add possible values e.g. to loglevel

11228ed

feat(ffi verify): add in default value

69233a6

feat(ffi verifier cli): handle both flags and options, along with mul…

3486281

…tiple

feat(ffi verifier cli): construct args string from inputs. Call pactf…

283dcef

…fi_free_string to cleanup

YOU54F added 2 commits July 7, 2023 21:07

test: skip cli ffi tests as issues with conflicting logs - pactffi_fe…

5b5dda9

…tch_log_buffer

chore(ci): macos arm64 set VERSION env var

a3810c5

YOU54F linked an issue Jul 11, 2023 that may be closed by this pull request

Installer #242

Closed

This was referenced Jul 11, 2023

Installer #242

Closed

Implement FFI interface for Provider #243

Closed

YOU54F linked an issue Jul 11, 2023 that may be closed by this pull request

Implement FFI interface for Provider #243

Closed

YOU54F added 13 commits July 26, 2023 16:04

chore: move PACT_FFI_PATH to constants

0811665

chore: update release script to support beta release tag formats

e492da6

feat(examples): showcase FFIVerify for HTTP

f7b75ea

feat: MessageProvider Verifier with FFIVerify plus examples

f1cea52

TODO - Message Metadata Content-Type hardcoded to application/json - Allow switching between rust/ruby core whilst in beta Notes - Message HTTP proxy needs to drop `contents`

Merge remote-tracking branch 'origin/master' into feat/ffi

5dea5dc

feat: MessageProvider now returns VerifyResult(return_code, logs)

e5d46e9

chore: avoid full path when checking for error message in test

c867226

chore(test): add PACT_DO_NOT_TRACK

6916758

chore(test): add PACT_DO_NOT_TRACK

6e69633

chore(test): windows has diff error for file not found

8c07bc3

chore!: drop ci testing of python 3.6 - fails in cirrus

28776c2

most likely due to container, see workaround in GHA

test: showcase grpc v4 pact verification

703bac6

use area calculator proto example matching up with other pact grpc examples. Pact is precreated and not currently generated from pact-python

ci(gha): test windows with plugins only

11ed3c2

YOU54F added 2 commits July 26, 2023 23:19

ci: renable all os

8ce9f57

chore(deps): update grpcio/grpcio-tools to latest

823fb49

YOU54F linked an issue Jul 26, 2023 that may be closed by this pull request

Drop support for Python < 3.7 #350

Closed

YOU54F added 3 commits July 27, 2023 18:11

test: add v2-http ffi verifier test with local pact

884fd8b

chore: reorder shutdown before getting logs

0317427

seems to causing hanging tests on windows

chore: pactffi_string_delete after decoding pactffi_verifier_logs

aa6fad5

YOU54F mentioned this pull request Jul 27, 2023

Feat/ffi consumer #366

Closed

YOU54F closed this Aug 2, 2023

JP-Ellis mentioned this pull request Sep 27, 2023

Pact FFI Tracking Issue #396

Open

47 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/ffi - load full ffi namespace, initial ffi verifier #357

Feat/ffi - load full ffi namespace, initial ffi verifier #357

YOU54F commented Jul 8, 2023 •

edited

YOU54F commented Jul 26, 2023 •

edited

YOU54F commented Aug 2, 2023

Feat/ffi - load full ffi namespace, initial ffi verifier #357

Feat/ffi - load full ffi namespace, initial ffi verifier #357

Conversation

YOU54F commented Jul 8, 2023 • edited

TODO

YOU54F commented Jul 26, 2023 • edited

YOU54F commented Aug 2, 2023

YOU54F commented Jul 8, 2023 •

edited

YOU54F commented Jul 26, 2023 •

edited