Fix hatch test scripts #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hatch scripts allow for additional arguments to be specified through the
`{args:<default>}` placeholder. Unfortunately, this was not
automatically enabled.
In doing this, I have also simplified the scripts by moving some common
pytest options into pytest's own `addopts` option.
Signed-off-by: JP-Ellis <josh@jpellis.me>
To help ensure there is a unified experience when running any/all tests, we need to define this in the root directory. The rest of the example-specific `conftest.py` can remain in `examples/conftest.py`. Running `pytest` in the root directory will now correctly execute _all_ tests, including the examples. Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
mefellows
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Commits describe the individual changes:
fix(test): ignore internal deprecation warnings
chore(test): add pytest options in root
To help ensure there is a unified experience when running any/all tests,
we need to define this in the root directory. The rest of the
example-specific
conftest.pycan remain inexamples/conftest.py.Running
pytestin the root directory will now correctly execute alltests, including the examples.
chore: fix hatch test scripts
Hatch scripts allow for additional arguments to be specified through the
{args:<default>}placeholder. Unfortunately, this was notautomatically enabled.
In doing this, I have also simplified the scripts by moving some common
pytest options into pytest's own
addoptsoption.🚨 Breaking Changes🔥 Motivation🔨 Test Plan🔗 Related issues/PRs
hatch run testto support arguments #408