chore: exclude python 3.12 #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this stage, Python 3.12 is not supported. There is a separate PR already resolving this, but it requires an update to a dependency. Signed-off-by: JP-Ellis <josh@jpellis.me>
JP-Ellis
added
difficulty:easy
JP-Ellis
force-pushed
the
fix/python-312-wheels
branch
5 times, most recently
from
7ab7bd0
to
21972b1
Compare
This commit introduces a few fixes were uncovered by the previous commit. Specifically: - Explicitly test the FFI - Cleanup the hatch build script and created a new `UnsupportedPlatformError` exception. - Update the wheel inclusions. Signed-off-by: JP-Ellis <josh@jpellis.me>
The `yarl` dependency was initially only used in the test suite, but a previous commit made use of yarl's `URL` class and forgot to promote `yarl` to a main dependency of Pact Python. Signed-off-by: JP-Ellis <josh@jpellis.me>
JP-Ellis
force-pushed
the
fix/python-312-wheels
branch
from
21972b1
to
777c40f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
At this stage, Python 3.12 is not supported. There is a separate PR already resolving this, but it requires an update to a dependency.
Update
The resolution of build issues with Python 3.12 uncovered another issue related to the bundling of Ruby. These have been resolved as well.
🚨 Breaking Changes🔥 Motivation
Make sure that the CI pipelines work again.
🔨 Test Plan🔗 Related issues/PRs