fix(v3): add __next__ implementation #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The various Pact iterators are empty at this stage as the returned classes are not implemented. As a result, this merely tests that the FFI `*_next` functions return a null pointer which raises a `StopIteration` exception in Python. Signed-off-by: JP-Ellis <josh@jpellis.me>
JP-Ellis
added
difficulty:easy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
The various Pact iterators are empty at this stage as the returned classes are not implemented. As a result, this merely tests that the FFI
*_nextfunctions return a null pointer which raises aStopIterationexception in Python.🚨 Breaking Changes🔥 Motivation
Fix CI workflow
🔨 Test Plan
Has been tested locally
🔗 Related issues/PRs
None