Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Groundwork API for Provider #575

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Groundwork API for Provider #575

merged 3 commits into from
Mar 11, 2024

Conversation

JP-Ellis
Copy link
Contributor

@JP-Ellis JP-Ellis commented Feb 29, 2024 •
edited
Loading

📝 Summary

Groundwork to be able to verifier HTTP pacts.

🚨 Breaking Changes

🔥 Motivation

Part of the work for V3

🔨 Test Plan

CI Workflow

🔗 Related issues/PRs

@JP-Ellis JP-Ellis added type:feature New feature area:v3 Relating to the pact.v3 module labels Feb 29, 2024
@JP-Ellis JP-Ellis self-assigned this Feb 29, 2024
@JP-Ellis JP-Ellis marked this pull request as ready for review March 8, 2024 04:08
@JP-Ellis JP-Ellis changed the title chore(ffi): implement verifier handle Groundwork API for Provider Mar 8, 2024
@JP-Ellis
Copy link
Contributor Author

JP-Ellis commented Mar 8, 2024

The FFI implies that the verifier is the core entity; though I am still on the fence whether I should call the class Verifier or Provider. Given that a verifier only ever has a single provider (though I guess a provider may have multiple verifiers), it might be more intuitive to rename the class.

@JP-Ellis
chore(ffi): implement verifier handle
a8bb28a 
Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis
feat(v3): add verifier class
8919f5b 
Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis
chore(v3): add basic verifier tests
6d753bb 
These tests are purely meant to detect any issues with the FFI and
changes in any of the verifier methods.

The compatibility suite will ensure that the verifier is functioning
correctly.

Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis JP-Ellis merged commit 97bbf76 into master Mar 11, 2024
26 of 27 checks passed
@JP-Ellis JP-Ellis deleted the feat/verifier-groundwork branch March 11, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JP-Ellis JP-Ellis

Labels
area:v3 Relating to the pact.v3 module type:feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Groundwork API for Provider API using Rust backend
1 participant
@JP-Ellis