chore(deps): refactor dependencies #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JP-Ellis
added
difficulty:easy
JP-Ellis
force-pushed
the
chore/refactor-dependencies
branch
from
71f951b
to
c8b6269
Compare
The main change is to prefix the optional dependency groups used for development only with a `devel-`. For example, `pact-python[devel-types]` instead of `pact-python[types]`. This helps ensure that end-users don't get confused. There's also a little bit of minor reformatting. Signed-off-by: JP-Ellis <josh@jpellis.me>
JP-Ellis
force-pushed
the
chore/refactor-dependencies
branch
from
c8b6269
to
45730bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
devel-prefix.🚨 Breaking Changes🔥 Motivation
This helps ensure that end-users don't get confused. For example
pact-python[types]might indicate a new feature which supports typing (which it does not).🔨 Test Plan🔗 Related issues/PRs
None