Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v3): add verbose mismatches to logging #620

Merged
merged 1 commit into from Mar 12, 2024
Merged

Conversation

JP-Ellis
Copy link
Contributor

馃摑 Summary

If the Pact Server exits with mismatches, an error is raised. In addition, the mismatches are exported as a JSON to the logger. This new behaviour can be disabled by setting verbose=False when starting the server.

馃毃 Breaking Changes

馃敟 Motivation

Improved end-user experience to see the mismatches (and fix them).

馃敤 Test Plan

Unit test added

馃敆 Related issues/PRs

None

If the Pact Server exits with mismatches, an error is raised. In
addition, the mismatches are exported as a JSON to the logger. This new
behaviour can be disabled by setting `verbose=False` when starting the
server.

Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis JP-Ellis added type:feature New feature difficulty:easy A simple task appropriate for newcomers to the codebase area:v3 Relating to the pact.v3 module labels Mar 12, 2024
@JP-Ellis JP-Ellis self-assigned this Mar 12, 2024
@JP-Ellis JP-Ellis merged commit 5206dbd into master Mar 12, 2024
29 of 30 checks passed
@JP-Ellis JP-Ellis deleted the feat/verbose-mismatch branch March 12, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:v3 Relating to the pact.v3 module difficulty:easy A simple task appropriate for newcomers to the codebase type:feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant