Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test logging #624

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Improve test logging #624

merged 2 commits into from
Mar 12, 2024

Conversation

JP-Ellis
Copy link
Contributor

📝 Summary

Improve test logging

🚨 Breaking Changes

🔥 Motivation

Improved debugging experience

🔨 Test Plan

None required

🔗 Related issues/PRs

None

While debugging a flaky test, I realised that `truncate` was applied to
the key-value pair, instead of just the value part. This made debugging
more difficult than it ought have been.

Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis JP-Ellis added difficulty:easy A simple task appropriate for newcomers to the codebase area:tests Relating to the testing type:chore Part of regular code upkeep labels Mar 12, 2024
@JP-Ellis JP-Ellis self-assigned this Mar 12, 2024
@JP-Ellis JP-Ellis changed the title Chore/test qol Improve test logging Mar 12, 2024
@JP-Ellis JP-Ellis merged commit 116bc9a into master Mar 12, 2024
23 of 30 checks passed
@JP-Ellis JP-Ellis deleted the chore/test-qol branch March 12, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tests Relating to the testing difficulty:easy A simple task appropriate for newcomers to the codebase type:chore Part of regular code upkeep
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant