Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support client language in verification results #307

Open
mefellows opened this issue Aug 4, 2023 · 1 comment
Open

Support client language in verification results #307

mefellows opened this issue Aug 4, 2023 · 1 comment
Labels
smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear

Comments

@mefellows
Copy link
Member

When the verification results are sent to the broker, the implementation values are hard coded to the Pact-Rust and the version of the crate:

"verifiedBy": { "implementation": "Pact-Rust", "version": "1.0.4" },

It would be ideal for the client language (JS, Go etc.) to be represented in here somewhere, so that we can display them in the Pact Broker interface, help when debugging etc.

Perhaps we need a way to represent both the wrapper language and the core?
@mefellows mefellows added feature request smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear labels Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

👋 Hi! The 'smartbear-supported' label has just been added to this issue, which will create an internal tracking ticket in PactFlow's Jira (PACT-1240). We will use this to prioritise and assign a team member to this task. All activity will be public on this ticket. For now, sit tight and we'll update this ticket once we have more information on the next steps.

See our documentation for more information.

rholshausen added a commit that referenced this issue Feb 19, 2024
@rholshausen
feat(verifier): Add the verifier version to the published results #307
6962fce
rholshausen added a commit that referenced this issue Feb 19, 2024
@rholshausen
Revert "feat(verifier): Add the verifier version to the published res…
167c445 
…ults #307"

This reverts commit 6962fce.
rholshausen added a commit that referenced this issue Feb 19, 2024
@rholshausen
feat(verifier): Add the verifier version to the published results #307
762f68e
rholshausen added a commit that referenced this issue Feb 19, 2024
@rholshausen
chore(verifier): Bump minor version #307
6975203
rholshausen added a commit that referenced this issue Feb 19, 2024
@rholshausen
feat(verifier): Add the client language to the verification results i…
2b5148b 
…f set #307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mefellows