Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pact_mock_server_cli osx aarch64 #266

Merged

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Apr 12, 2023

pact_mock_server_cli

  • Add aarch64-apple-darwin target for pact_mock_server_cli
  • Adds smoke test for aarch64-apple-darwin target for pact_mock_server_cli

Bonus

  • Adds smoke test for aarch64-apple-darwin target for pact_mock_server_cli
  • Adds smoke test for aarch64-unknown-linux-gnu target for pact_verifier_cli
  • Adds smoke test for aarch64-unknown-linux-gnu target for pact_verifier_cli

 Supported Platforms

OS Architecture Supported
OSX x86_64
OSX aarch64 (arm)
Linux x86_64
Linux aarch64 (arm)
Windows x86_64

Testing

CI can be run locally with tart.run and cirrus-cli on a mac machine with tart run in the root folder.

Cirrus-CI account needed for cloud testing of ARM64 machines, all testable within the free tier and no credit card needed


linux_arm64_task:
arm_container:
image: rustlang/rust:nightly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to need nightly here, I would prefer to run on stable and/or beta

Copy link
Member Author

@YOU54F YOU54F Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I would have thought that too, I chose it as it was from the release flow where these get built

- uses: actions-rs/toolchain@v1
with:
toolchain: nightly

Although that only appears before the FFI run (which is maybe more suspect) especially in a release run

kicked off a run against stable tag now - https://cirrus-ci.com/build/4982626734309376

@rholshausen rholshausen merged commit 1116eff into pact-foundation:master Apr 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants