Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the 'combine' key in matching rules #63

Closed
wants to merge 1 commit into from

Conversation

acarpe
Copy link

@acarpe acarpe commented Nov 6, 2018

Verifing a pact produced by pact-jvm in V3 format it fails with this error:

pact-support-1.8.0/lib/pact/matching_rules/v3/merge.rb:124:in `block (2 levels) in log_ignored_rules': undefined method `any?' for "AND":String (NoMethodError)

it fails because the matching rules contain the combine key

      "matchers": [ { "match": "type" } ],
      "combine": "AND"
}```

in order to make it works again I remove the `combine` key from the hash because it is not relevant to log the unsupported matcher

@bethesque
Copy link
Member

I have fixed this in a different way in cd52108

@bethesque bethesque closed this Nov 15, 2018
@bethesque
Copy link
Member

Released in 1.8.1 of pact-support.

@bethesque
Copy link
Member

It is quite relevant to log the unsupported matcher, because the rules that the consumer has written are not being applied. It's important to know that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants