Chore/step1 react deps #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey should be updated and all sorted now across all steps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys! After running
npm installfrom the step1 folder, when attempting to runnpm start --prefix consumerit resulted inAttempted import error: 'Routes' is not exported from 'react-router-dom'.I tried the react package versions from the master branch package.json and this appears to resolve the issue.
Used npm v 8.9.0 with Node v16.17.0 to generate the lock file
Note: I also added pact, nock, rimraf as they are needed in step2 onwards. Perhaps this is not the intention though, and you want people to be looking at the package json and running 'npm install' again for the subsequent steps?