Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Thor usage error when there are unknown options specified #146

Closed
bethesque opened this issue Oct 9, 2023 · 2 comments · Fixed by #147
Closed

Update Thor usage error when there are unknown options specified #146

bethesque opened this issue Oct 9, 2023 · 2 comments · Fixed by #147
Labels
smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear

Comments

@bethesque
Copy link
Member

See thread about incorrect dash character not causing an error: https://pact-foundation.slack.com/archives/CLS16AVEE/p1694604476214169

https://mattbrictson.com/blog/fixing-thor-cli-behavior
@bethesque bethesque added the smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear label Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

👋 Hi! The 'smartbear-supported' label has just been added to this issue, which will create an internal tracking ticket in PactFlow's Jira (PACT-1370). We will use this to prioritise and assign a team member to this task. All activity will be public on this ticket. For now, sit tight and we'll update this ticket once we have more information on the next steps.

See our documentation for more information.

@bethesque bethesque changed the title Update Thor usage to behave like a normal CLI Update Thor usage error when there are unknown options specified Oct 13, 2023
@YOU54F YOU54F linked a pull request Oct 13, 2023 that will close this issue
feat: print warnings and allow error to be raised when unknown option is used #147
Merged
@bethesque
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear
Projects
None yet
Milestone
No milestone
1 participant
@bethesque