feat: print warnings and allow error to be raised when unknown option is used #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is used PACT-1370
Old behaviour with unknown option
|
YOU54F
reviewed
Oct 13, 2023
|
|
||
| From version 1.73.0, warnings will be printed for unknown options, and if the environment variable `PACT_BROKER_ERROR_ON_UNKNOWN_OPTION=true` is set, an error will be raised when an unknown option is used. | ||
|
|
||
| In the next major version, an error will be raised by default. |
YOU54F
reviewed
Oct 13, 2023
| stderr_lines = stderr.readlines | ||
| end | ||
|
|
||
| expect(stderr_lines.join("\n")).to include(unknown_switches_text) |
There was a problem hiding this comment.
it's a shame it says unknown switches rather than unknown Option but this is still a much better experience
Usage:
pact-broker publish PACT_DIRS_OR_FILES ... -a, --consumer-app-version=CONSUMER_APP_VERSION -b, --broker-base-url=BROKER_BASE_URL
Options:
-a, --consumer-app-version=CONSUMER_APP_VERSIO
There was a problem hiding this comment.
Yes, the terminology used inside the gem is very inconsistent. The words argument, option and switch are all used to mean the same thing in various places. I guess it's what happens when you have multiple people working on a project and you don't have a Terminology Dictator in control.
YOU54F
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PACT-1370