Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updating pending and wip logic #432

Merged
merged 9 commits into from
May 21, 2021

Conversation

bethesque
Copy link
Member

Current logic for determining the WIP pacts list ends with:

  1. Discard all the pacts that were published before the first instance of this provider tag (this is so that if you create a brand new provider branch, you don't get EVERY head pact included in the WIP pacts list).

The problem with this is that feature pacts created before a provider's feature branch is created don't get included.

See #427 and https://github.com/pact-foundation/pact_broker/blob/a59f19b27f1d01a48ff62e55b81e9c27cbdde2fe/script/reproduce-issue-starting-up.rb

This PR changes the last condition to:

  1. Discard all the pacts that were explicitly selected and successfully verified by another branch of the provider before this branch was created (this is so that if you create a brand new provider branch, you don't get EVERY head pact included in the WIP pacts list).

@bethesque
Copy link
Member Author

It also changes the pending logic from:

A pact content is considered pending if there has not been a successful published verification by the specified branch of the provider.

to

A pact content is considered pending if there has not been a successful published verification by the specified branch of the provider, and there wasn't a successful published verification from a different branch from before this branch was created.

@bethesque bethesque merged commit db643d3 into master May 21, 2021
@bethesque bethesque deleted the feat/updating-pending-and-wip-logic branch May 21, 2021 03:34
@solarmosaic-kflorence
Copy link
Contributor

We should add this to the list of things to update in the WIP/pending docs: pact-foundation/docs.pact.io#26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants