Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Display pagination correctly in index page with tag #469

Merged
merged 1 commit into from Jul 13, 2021
Merged

fix: Display pagination correctly in index page with tag #469

merged 1 commit into from Jul 13, 2021

Conversation

bangn
Copy link
Contributor

@bangn bangn commented Jul 12, 2021

The partial view index/_pagination.haml needs a div.pagination tag in order to display pagination correctly.
However, index/show-with-tags was using p.pagination instead.
Fix by changing the tag to div.pagination

@bangn
Copy link
Contributor Author

bangn commented Jul 12, 2021

Current view
image

@bangn bangn mentioned this pull request Jul 12, 2021
Closed
@bethesque
Copy link
Member

Ah! Thank you :D

@bethesque bethesque merged commit cda9c15 into pact-foundation:master Jul 13, 2021
@bangn bangn deleted the issue-457 branch July 15, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bangn @bethesque