chore: add method to automatically determine the model associations required to be eager loaded for a decorator #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ired to be eager loaded for a decorator PACT-1070
Inksprout
approved these changes
Jun 19, 2023
vwong
approved these changes
Jun 19, 2023
bethesque
added a commit
that referenced
this pull request
Mar 22, 2024
…ired to be eager loaded for a decorator (#621) PACT-1070
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PACT-1070
Inspect the attributes on the decorator class to automatically determine which associations should be eager loaded on the models that will be used to render the response. These will generally be any attributes that are collections, embedded, or nested. For any decorator where this doesn't hold true (due to a mismatch between the way we render the resource, and the way it is stored) then we can overwrite this method (the webhook model+decorator is the pair that springs to mind, as we nest the
requestobject inside the webhook resource, but it doesn't have a separate table in the database).